On Wed, Jul 13, 2016 at 01:47:52PM +0200, Martin Kletzander wrote: > On Wed, Jul 13, 2016 at 11:18:28AM +0100, Daniel P. Berrange wrote: > > If you invoke virDomainLxcEnterSecurityLabel() on security > > model of "none" it will report an error. Logically a "none" > > security model should be treated as a no-op, so we should > > just return success immediately, instead of an error. > > > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > --- > > src/libvirt-lxc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > ACK for this, just one question though. Shouldn't there be support for > DAC as well or is that done by default somewhere else? This is only used with LXC right now, and that doesn't use the DAC security driver. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list