On Wed, Apr 29, 2009 at 01:14:05PM +0200, Pritesh Kothari wrote: > Hi All, > > PATCH 1/1: contains changes in version detection and moving a global variable > in the global struct, so that no more global vairables exists. > + if (uVersion >= 2001052 && uVersion < 2002051) { > + DEBUG0("VirtualBox API version: 2.2"); > + driver = &vbox22Driver; > + } else if (uVersion >= 2002051 && uVersion < 2005051) { > + DEBUG0("VirtualBox API version: 2.5"); > + driver = &vbox25Driver; > + } else { > + DEBUG0("Unsupport VirtualBox API version"); > + } This bit seems to cause a link error for the driver, because nothing is defined the vbox25Driver symbol. I guess you have another patch pending to add vbox_V2_5.c ? I just #if 0'd the 'else if' block to make it link Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list