On Mon, Jul 11, 2016 at 05:42:41PM +0200, Martin Kletzander wrote:
On Mon, Jul 11, 2016 at 04:11:22PM +0200, Michal Privoznik wrote:In an unlikely event of execve() failing, the virCommandExec() function does not report any error, even though checks that are at the beginning of the function are verbose when failing. Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- src/util/vircommand.c | 7 +++++- tests/commandtest.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 75 insertions(+), 1 deletion(-)Looks good, but the tests sometimes fails on me with "Child should have returned an error". You might want to investigate that.
Also I get: tests/commandtest.c:1086: pid = fork(); When running make syntax-check...
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list