Re: [PATCH 0/2] qemu: use -display none instead of -nographic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05.07.2016 14:35, Paolo Bonzini wrote:
> -display none is preferrable to -nographic which (in addition to
> disabling graphics output) redirects the serial port to stdio and on
> OpenBIOS enables the firmware's serial console.
> 
> Paolo Bonzini (2):
>   qemu: detect -display
>   qemu: generate -display none
> 
>  src/qemu/qemu_capabilities.c                       |  4 +++
>  src/qemu/qemu_capabilities.h                       |  1 +
>  src/qemu/qemu_command.c                            |  7 ++++-
>  src/qemu/qemu_parse_command.c                      |  4 +++
>  .../qemuargv2xml-nographics-vga-display.args       | 23 +++++++++++++++
>  .../qemuargv2xml-nographics-vga-display.xml        | 34 ++++++++++++++++++++++
>  tests/qemuargv2xmltest.c                           |  1 +
>  tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  1 +
>  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  1 +
>  .../caps_2.6.0-gicv2.aarch64.xml                   |  1 +
>  .../caps_2.6.0-gicv3.aarch64.xml                   |  1 +
>  tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml  |  1 +
>  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  1 +
>  tests/qemuhelptest.c                               |  6 ++--
>  .../qemuxml2argv-nographics-display.args           | 22 ++++++++++++++
>  .../qemuxml2argv-nographics-display.xml            | 25 ++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  2 ++
>  tests/qemuxml2xmltest.c                            |  2 +-
>  25 files changed, 140 insertions(+), 4 deletions(-)
>  create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nographics-vga-display.args
>  create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nographics-vga-display.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-nographics-display.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-nographics-display.xml
> 

Just to obey the formal side of the process, ACK series.

BTW: there are lots of '-nographic' in our
tests/qemuxml2argvdata/qemuxml2argv-*.args files, do we want to update
those to have '-display none' instead?

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]