On Tue, Jul 05, 2016 at 03:52:09PM +0200, Paolo Bonzini wrote:
>
>
> On 05/07/2016 14:59, Daniel P. Berrange wrote:
> > > if (!def->ngraphics) {
> > > - virCommandAddArg(cmd, "-nographic");
> > > + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) {
> > > + virCommandAddArg(cmd, "-display");
> > > + virCommandAddArg(cmd, "none");
> > > + } else {
> > > + virCommandAddArg(cmd, "-nographic");
> > > + }
> >
> > Am I right in thinking that -display none vs -nographic has *no* effect
> > on guest machine ABI ? I think we're safe based on my reading of it,
> > particularly since we use -nodefaults and -nodefconfig, but want to confirm
> > there's no edge case i'm not aware of.
>
> It changes one fw_cfg field from 0 to 1, but only OpenBIOS looks at it
> right now.
Ok, that's fine as PPC doesn't have versioned machine types anyway, so
its migration compat is doomed regardless :-)
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list