On 06/30/2016 11:14 AM, Cole Robinson wrote: > On 06/29/2016 05:37 PM, John Ferlan wrote: >> A post 2.0.0 type adjustment... >> >> While answering a question for bz 1289391 regarding the USB path - I figured >> that making the code be more the virtio and scsi code paths would at least >> have a better look'n'feel. Then I tripped in to the alias morass and cleaned >> that up a bit too. >> >> John Ferlan (5): >> qemu: Reorder qemuDomainAttachUSBMassStorageDevice failure path >> qemu: Move drive alias processing to qemu_alias >> qemu: Use qemuAssignDeviceDiskDriveAlias >> qemu: Make QEMU_DRIVE_HOST_PREFIX more private >> qemu: Add attempt to call qemuMonitorDriveDel for USB failure path >> > > Note there is https://bugzilla.redhat.com/show_bug.cgi?id=1336225 covering > some of these changes. There's also a missing drive_del call in AttachSCSI. > And in fact the whole drive_add, device_add, and unwinding on failure can > probably be shared between AttachVirtio/AttachUSB/AttachSCSI . Not saying it > blocks this series, but there's more cleanup in this area if you're motivated :) > I thought about touching AttachSCSI, but I knew I still had changes from the pending LUKS secret series and I didn't want to have to continue messing with it until that got pushed. And yes, as I was going through this I started thinking - there's a lot of similar code that perhaps could be combined. One thing at a time I guess though. Thanks! John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list