On Mon, Jun 27, 2016 at 04:43:48PM +0200, Marc Hartmayer wrote: > Verify that SCSI controllers get created automatically when a SCSI disk > is hot-plugged to a domain that doesn't have a matching SCSI controller > defined already. > > Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx> > --- > tests/qemuhotplugtest.c | 29 ++++++++++ > .../qemuhotplug-disk-scsi-2.xml | 8 +++ > ...-base-with-scsi-controller-live+disk-scsi-2.xml | 51 +++++++++++++++++ > ...se-without-scsi-controller-live+disk-scsi-2.xml | 66 ++++++++++++++++++++++ > ...argv-hotplug-base-with-scsi-controller-live.xml | 56 ++++++++++++++++++ > ...v-hotplug-base-without-scsi-controller-live.xml | 40 +++++++++++++ > 6 files changed, 250 insertions(+) > create mode 100644 tests/qemuhotplugtestdata/qemuhotplug-disk-scsi-2.xml > create mode 100644 tests/qemuhotplugtestdata/qemuhotplug-hotplug-base-with-scsi-controller-live+disk-scsi-2.xml > create mode 100644 tests/qemuhotplugtestdata/qemuhotplug-hotplug-base-without-scsi-controller-live+disk-scsi-2.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hotplug-base-with-scsi-controller-live.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hotplug-base-without-scsi-controller-live.xml ACK, top marks for adding unit tests ! Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list