On Mon, Jun 27, 2016 at 04:43:46PM +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and there is no proper SCSI > controller defined, it results in an "error: internal error: Could not > find scsi controller with index X required for device" error. > > For that reason reverting a hunk of the commit > d4d32005d6e8b2cc0a2f26b483ca1de10171db6d. > > This patch also adds an extra comment to the code to clarify the > loop. > > Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Bjoern Walk <bwalk@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx> > --- > src/qemu/qemu_hotplug.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list