Hi Laine, My apologies for having submitted the patch all butchered :( . I’ll be sure to start a new thread using the git send-email command from our local repo to provide a cleaner output. Thanks, Randy On 6/29/16, 12:32, "sendmail on behalf of Laine Stump" <justsendmailnothingelse@xxxxxxxxx on behalf of laine@xxxxxxxxx> wrote: >On 06/29/2016 02:44 PM, Randy Aybar (raybar) wrote: >> Hi Daniel, >> >> Just a gentle reminder that we’ve replied to your comments and >> awaiting further feedback. > >The patch that was attached to that email wasn't complete and couldn't >be applied - it had no header, simply beginning with the letter "I" >followed by a +. > >Aside from that, it makes it much easier to review patches (and thus >more likely for them to be reviewed in a timely manner) if they are sent >directly as self-contained emails using "git send-email" rather than >sending the output of "git diff" as an attachment to an email message. >Also, post new versions of a patch using the -v2 (-v3, etc) option to >git send-email so that they will show up with, e.g. "[PATCH v2]" in the >subject. See the libvirt contributors' guidelines here: > > https://libvirt.org/hacking.html > >(ignore the short bit about using "diff -urp" or "git diff" - that is >ancient cruft that should have been removed long ago. Instead, you >should commit your changes to a local branch, then use git send-email to >send the patch.) > >Finally, the commit log message should be a short paragraph about what >is implemented; your original patch message included a large treatise on >the subject, and the "v2" patch contained no header at all. Take a look >at "git log" to get a feel for what is appropriate. > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list