Re: [PATCH 0/6] events: don't mandate a uuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/28/2016 02:18 PM, John Ferlan wrote:
> 
> 
> On 06/23/2016 12:27 PM, Cole Robinson wrote:
>> The generic event infrastructure has the notion of lookup-by-uuid
>> baked into the API, but not all objects have a uuid (nodedev,
>> interfaces).
>>
>> This series enables callers to specify a string key for match
>> purposes. Existing users of the binary uuid value now pass in a
>> converted uuid string.
>>
>> Cole Robinson (6):
>>   events: Privatize virObjectEventCallback
>>   events: Add virObjectEventCallbackFree
>>   events: Cleanup callback variable name
>>   events: Pass in UUID as a string
>>   events: Add explicit lookup 'key' value
>>   events: Rename argument uuid->key
>>
>>  src/conf/domain_event.c         |  28 +++++--
>>  src/conf/network_event.c        |  16 +++-
>>  src/conf/object_event.c         | 170 +++++++++++++++++++++-------------------
>>  src/conf/object_event.h         |   3 -
>>  src/conf/object_event_private.h |   8 +-
>>  src/conf/storage_event.c        |  16 +++-
>>  6 files changed, 145 insertions(+), 96 deletions(-)
>>
> 
> Beyond the noted issue in patch 5 ...
> 
> ACK series,
> 

Thanks, I have that issue fixed locally already. I'll push after the release

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]