Re: [PATCH 2/2] qemu: use virXMLNodeSanitizeNamespaces()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 24, 2016 at 11:33:51 -0400, Laine Stump wrote:
> Replace the virDomainDef-specific virDomainDefMetadataSanitize() with
> virXMLNodeSanitizeNamespaces().
> ---
>  src/conf/domain_conf.c | 56 ++------------------------------------------------
>  1 file changed, 2 insertions(+), 54 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 75ad03f..efc95f7 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c

[...]

> @@ -4504,7 +4451,8 @@ virDomainDefPostParseInternal(virDomainDefPtr def,
>      }
>  
>      /* clean up possibly duplicated metadata entries */
> -    virDomainDefMetadataSanitize(def);
> +    if (def->metadata)

This condition is integrated into the funciton so you can call it
directly

ACK if you squash this to the previous patch. Code movement patches are
generally okay together.

Peter

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]