On 06/24/2016 12:31 PM, Daniel P. Berrange wrote: > On Thu, Jun 16, 2016 at 10:08:55AM +0200, Jovanka Gulicoska wrote: >> Storage pool lifecycle event API entry points for registering and deregistering >> storage pool events, as well as types of events associated with storage pools. >> These entry points will be used for implementing asynchronous lifecycle events. >> >> Storage pool API: >> virConnectStoragePoolEventRegisterAny >> virConnectStoragePoolEventDeregisterAny >> virStoragePoolEventLifecycleType which has events STARTED, STOPPED, DEFINED, >> UNDEFINED, and REFRESHED > > This is wrong. A storage pool refresh is *not* a lifecycle change, as there > is no transition involved - the pool is simply running the whole time. > Hmm, in my head I was thinking more 'we emit DEFINED event when guest XML is redefined/changed, refresh often implies changed XML, so make it a LIFECYCLE event liked DEFINED', but indeed it doesn't really have a true state component to it so I'll defer to your judgement here. > We should have a completely separate event for notifying of refreshes. > > This is critical to fix before the 2.0.0 release, so I will shortly > send patches to fix the API in this respect. Reviewing your patch now... Thanks, Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list