On 06/22/2016 01:37 PM, Laine Stump wrote: > virDomainNetIPInfoFormat() and virDomainNetIPInfoParseXML() were > previously defined as global functions (but declared in the .c file > directly above their definition) to avoid the "static function defined > but not called" error during compile. Now that both are used, they can > be properly defined as static functions. And since > virDomainNetIPInfoFormat() is now the only caller of > virDomainNetIPsFormat() and virDomainNetRoutesFormat(), those two > functions can simply be subsumed into virDomainNetIPInfoFormat(). > --- > src/conf/domain_conf.c | 46 ++++++++++------------------------------------ > 1 file changed, 10 insertions(+), 36 deletions(-) > See my follow up to other patch - using the ATTRIBUTE_UNUSED for an unused static function is something I've done in the past. That then just turns this patch into a "merge" of the Format functions (and reduces the commit message a bit). ACK with the adjustments... John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list