Re: [PATCH 7/7] Rename virNetServerClient*AddrString

Ján Tomko <jtomko@xxxxxxxxxx> · Thu, 23 Jun 2016 22:41:24 +0200

On Wed, Jun 22, 2016 at 07:43:08PM -0400, John Ferlan wrote:


On 06/20/2016 10:27 AM, Ján Tomko wrote:
Add SASL at the end to make the format obvious.
---
 daemon/remote.c              | 4 ++--
 src/libvirt_remote.syms      | 4 ++--
 src/rpc/virnetserverclient.c | 4 ++--
 src/rpc/virnetserverclient.h | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/daemon/remote.c b/daemon/remote.c
index ea4753f..5ee82bb 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -3028,8 +3028,8 @@ remoteDispatchAuthSaslInit(virNetServerPtr server ATTRIBUTE_UNUSED,

     sasl = virNetSASLSessionNewServer(saslCtxt,
                                       "libvirt",
-                                      virNetServerClientLocalAddrString(client),
-                                      virNetServerClientRemoteAddrString(client));
+                                      virNetServerClientLocalAddrStringSASL(client),
+                                      virNetServerClientRemoteAddrStringSASL(client));
     if (!sasl)
         goto authfail;


Based purely on my comment from 1/7 - Does remoteAuthSASL need to be
adjusted too?

Right, I forgot to rename the virNetClient*AddrString functions.


ACK for this, but I wanted to make sure to ask.

Thanks, I've pushed the series and sent the missing rename separately.

Jan

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list







