On 06/16/2016 07:08 AM, John Ferlan wrote: > Extracted from the LUKS series (patches 4-9 and patch 14): > > http://www.redhat.com/archives/libvir-list/2016-June/msg00804.html > > with a couple of modifications as I working through the TLS code... > > 1. Instead of looking the LookupDef 'secdef', call it 'seclookupdef' > (it's just clearer that way I think) > > 2. Likewise, change the ParseSecret and FormatSecret to add "Lookup" > > John Ferlan (7): > storage: Use virSecretGetSecretString > secret: Move virStorageSecretType and rename > util: Move and rename virStorageAuthDefParseSecret > util: Introduce virSecretFormatSecret > qemu: Change protocol parameter for secret setup > qemu: Remove authdef from secret setup > conf: Add new secret type "key" > > docs/aclpolkit.html.in | 4 ++ > docs/formatsecret.html.in | 57 +++++++++++++++- > docs/schemas/secret.rng | 10 +++ > include/libvirt/libvirt-secret.h | 3 +- > po/POTFILES.in | 1 + > src/Makefile.am | 2 + > src/access/viraccessdriverpolkit.c | 13 ++++ > src/conf/secret_conf.c | 26 ++++++- > src/conf/secret_conf.h | 3 +- > src/conf/virsecretobj.c | 5 ++ > src/libvirt_private.syms | 7 ++ > src/libxl/libxl_conf.c | 2 +- > src/qemu/qemu_domain.c | 131 ++++++++++++++++++++++-------------- > src/secret/secret_util.c | 18 ++--- > src/secret/secret_util.h | 10 +-- > src/storage/storage_backend_iscsi.c | 54 +++------------ > src/storage/storage_backend_rbd.c | 49 ++------------ > src/util/virsecret.c | 124 ++++++++++++++++++++++++++++++++++ > src/util/virsecret.h | 56 +++++++++++++++ > src/util/virstoragefile.c | 103 +++++++--------------------- > src/util/virstoragefile.h | 17 +---- > tests/qemuargv2xmltest.c | 4 +- > tests/secretxml2xmlin/usage-key.xml | 7 ++ > tests/secretxml2xmltest.c | 1 + > 24 files changed, 451 insertions(+), 256 deletions(-) > create mode 100644 src/util/virsecret.c > create mode 100644 src/util/virsecret.h > create mode 100644 tests/secretxml2xmlin/usage-key.xml > With Peter's review of the LUKS series, these no longer are necessary to review separately. John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list