On 06/23/2016 08:26 AM, Ján Tomko wrote: > > Also, calling virDomainDefPostParse after device coldplug is strange, > we should be adding a device that does not need ajdustments. > I just want to note that in general I don't agree with this (I'd need to look at the actual code though). IMO coldplug APIs should be implemented as close to manual coldplug as possible, ala virsh edit, since that's effectively what it is. If we don't run a DefPostParse here and trigger all those code paths that a normal redefine hits, we risk generating some XML config that will fail to validate on the next unrelated XML redefine. Maybe there's a better way to handle it by not calling DomainDefPostParse explictly, but I think it needs to go through all the same code paths that a redefine would, outside of reparsing the XML. Thanks, Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list