Re: [libvirt-python][PATCH] Add support for virDomainGetGuestVcpus

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 23.06.2016 09:11, Pavel Hrdina wrote:
> On Thu, Jun 23, 2016 at 06:57:11AM +0200, Michal Privoznik wrote:
>> This function has virTypedParameterPtr as one of the args and our
>> generator is unable to deal with that. Therefore we must provide
>> implementation.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
>> ---
> 
> [...]
> 
>> +static PyObject *
>> +libvirt_virDomainGetGuestVcpus(PyObject *self ATTRIBUTE_UNUSED,
>> +                               PyObject *args)
>> +{
>> +    PyObject *pyobj_domain;
>> +    virDomainPtr domain;
>> +    virTypedParameterPtr params = NULL;
>> +    int nparams = 0;
>> +    unsigned int flags;
>> +    int i_retval;
>> +    PyObject *ret = NULL;
>> +
>> +    if (!PyArg_ParseTuple(args, (char *)"OI:virDomainGetScedulerParametersFlags",
> 
> s/virDomainGetScedulerParametersFlags/virDomainGetGuestVcpus/

Ah, copy paste error. Thanks for catching that.

> 
>> +                          &pyobj_domain, &flags))
>> +        return NULL;
>> +    domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain);
>> +
>> +    LIBVIRT_BEGIN_ALLOW_THREADS;
>> +    i_retval = virDomainGetGuestVcpus(domain, &params, &nparams, flags);
>> +    LIBVIRT_END_ALLOW_THREADS;
> 
> ACK
> 

Thank you! Pushed.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list