Re: [PATCH 3/4] Check for VFIO too where the Legacy passthrough is checked

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-06-15 at 09:57 +0000, Shivaprasad G Bhat wrote:
> On PPC the Legacy patthrough is not supported and only

s/patthrough/passthrough/

> VFIO is supported. So, the checks at places to confirm if the
> host is passthrough capable checks only Legacy, fix it. This
> is seen at only one place now.
> 
> Signed-off-by: Shivaprasad G Bhat <sbhat@xxxxxxxxxxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 65ef68c..6b316a0 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -18413,7 +18413,8 @@ qemuConnectGetDomainCapabilities(virConnectPtr conn,
>  
>      cfg = virQEMUDriverGetConfig(driver);
>  
> -    if (qemuHostdevHostSupportsPassthroughLegacy())
> +    if (qemuHostdevHostSupportsPassthroughLegacy() ||
> +        qemuHostdevHostSupportsPassthroughVFIO())
>          virttype = VIR_DOMAIN_VIRT_KVM;
>      else
>          virttype = VIR_DOMAIN_VIRT_QEMU;

This looks like an unrelated bugfix. If that's the case,
please yank it out of the series and submit it separately.

Looks good otherwise :)

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]