Re: [PATCH 08/17] Do not call postParse with ABI_UPDATE when parsing cmdline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 17, 2016 at 20:07:10 +0200, Ján Tomko wrote:
> So far this is only useful for recalculating NUMA memory size,
> which this function cannot parse.
> 
> This will let us generate USB addresses based on this flag.
> ---
>  src/qemu/qemu_parse_command.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
> index 927bd79..1d54a68 100644
> --- a/src/qemu/qemu_parse_command.c
> +++ b/src/qemu/qemu_parse_command.c
> @@ -2626,8 +2626,7 @@ qemuParseCommandLine(virCapsPtr caps,
>  
>      VIR_FREE(nics);
>  
> -    if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE,
> -                              xmlopt) < 0)
> +    if (virDomainDefPostParse(def, caps, 0, xmlopt) < 0)
>          goto error;

Additionally ABI update is not desired in case when this function is
used in the qemu-attach API. Thankfully that doesn't work in most cases
either so I didn't manage to break much.

ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]