On 06/17/2016 09:47 AM, Joao Martins wrote: > From: Jim Fehlig <jfehlig@xxxxxxxx> > > Commit 2a58ed0b added support for creating guests with USB > hostdevs. Commit fc21d10 later added support for hotplut of > USB hostdevs. Advertise support for USB hostdevs in the > domcapabilities. > > In addition add the appropriate caps for USB support on > domaincapstest when libvirt is built on a Xen with > LIBXL_HAVE_PVUSB. Otherwise domaincapstest would fail i.e. > testing the wrong domain capabilities. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> > --- > Changes since v2: > - Change domaincapstest to target (non-)PVUSB caps. > --- > src/libxl/libxl_capabilities.c | 5 ++ > tests/domaincapsschemadata/libxl-xenfv-usb.xml | 69 ++++++++++++++++++++++++++ > tests/domaincapsschemadata/libxl-xenpv-usb.xml | 59 ++++++++++++++++++++++ > tests/domaincapstest.c | 12 ++++- > 4 files changed, 143 insertions(+), 2 deletions(-) > create mode 100644 tests/domaincapsschemadata/libxl-xenfv-usb.xml > create mode 100644 tests/domaincapsschemadata/libxl-xenpv-usb.xml ACK. Thanks for fixing up the tests. I knew there was a failure, but got side-tracked and then ended up sending V1 before even attempting to fix it :-). I've made sure this passes all my pre-commit tests (included a configuration without-xen and without-libxl) and have now pushed it. Regards, Jim -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list