Re: [PATCH 2/2] tests: mark virsh-optparse and virsh-synopsis as expensive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 16, 2016 at 10:46:43 +0200, Ján Tomko wrote:
> virsh-synopsis takes even longer than virsh-all which is
> already makred as expensive.
> ---
>  tests/virsh-optparse | 2 ++
>  tests/virsh-synopsis | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/tests/virsh-optparse b/tests/virsh-optparse
> index cbd6c30..cb0f3d4 100755
> --- a/tests/virsh-optparse
> +++ b/tests/virsh-optparse
> @@ -19,6 +19,8 @@
>  
>  . "$(dirname $0)/test-lib.sh"
>  
> +test_expensive
> +
>  # If $abs_top_builddir/tools is not early in $PATH, put it there,
>  # so that we can safely invoke "virsh" simply with its name.
>  case $PATH in
> diff --git a/tests/virsh-synopsis b/tests/virsh-synopsis
> index d0d1197..60446dc 100755
> --- a/tests/virsh-synopsis
> +++ b/tests/virsh-synopsis

I think we could drop this test completely together with virsh-all if we
add small C program or perhaps add a switch to virsh that will iterate
the cmdGroups[] array declared in virsh (that should be simple enough
to extract) and will call the checks that make sure that the the command
and argument help strings are present.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]