On Wed, Jun 15, 2016 at 05:15:10PM +0200, Andrea Bolognani wrote: > On Wed, 2016-06-15 at 10:31 -0400, Laine Stump wrote: > > On 06/15/2016 09:03 AM, Andrea Bolognani wrote: > > > > > > This allows us to produce releases that are roughly a third in > > > size, have no limitation on path length, and are still readable > > > by all supported platforms. > > > --- > > > > I just want to point out that the tarfile is built every time you run > > "make rpm" (which I do quite a lot - I prefer installing rpms to the > > carnage created by make install), and this increases the time for make > > rpm on my system by 1min38sec. (jtomko may have something to say about > > that, since he's been interested in shaving fractions of a second off > > the build time in the last few days :-O) > > > > Am I going to need to carry a local patch to revert this so that I don't > > get *even more* bored waiting for builds to complete? Or is there a > > reasonable way to make it easily configurable with a switch to autogen? > > (even then I would still need a patch to the specfile, unless we could > > make it happen based on some environment setting). > > > > (Aside from that, I applied the patch and it does work). > > This might just be the perfect chance for you to start > running libvirtd from the build directory instead - that way, > you can save both the time needed to make dist and the time > needed to install the new rpm! :) > > In all seriousness though, this is a reasonable concern, > thanks for bringing it up. I don't have any bright ideas on > how to make this configurable, short of pre-processing > configure.ac and libvirt.spec.in[1] in autogen.sh. Hopefully > someone else on the list will come up with a better plan - > it would be a shame not to take advantage of xz compression. Honestly, I think developers should not be using make rpm / make install for their day to day development - the only time you should need to use 'make rpm' is if you actually explicitly want to verify RPM packaging. We've gone to the trouble of making it possible to directly run libvirt from the build directory for all developer use cases. If there's something important that doesn't work when run from the build dir we should fix it. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list