On 06/15/2016 02:01 AM, Martin Kletzander wrote:
> On Tue, Jun 14, 2016 at 07:21:31PM -0400, Cole Robinson wrote:
>> On 06/14/2016 04:29 PM, Jovanka Gulicoska wrote:
>>> Changes since v2: fix comment formating, change in comment,
>>> move REMOTE_PROC_STORAGE_POOL_EVENT_LIFECYCLE to buttom of list
>>> ---
>>> daemon/libvirtd.h | 2 +
>>> daemon/remote.c | 207
>>> ++++++++++++++++++++++++++++++++++++++++++-
>>> src/remote/remote_driver.c | 128 ++++++++++++++++++++++++++
>>> src/remote/remote_protocol.x | 43 ++++++++-
>>> src/remote_protocol-structs | 16 ++++
>>> 5 files changed, 392 insertions(+), 4 deletions(-)
>>
>>> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
>>> index fe1b8a8..85bc62d 100644
>>> --- a/src/remote_protocol-structs
>>> +++ b/src/remote_protocol-structs
>>> @@ -2551,6 +2551,22 @@ struct remote_network_event_lifecycle_msg {
>>> int event;
>>> int detail;
>>> };
>>> +struct remote_connect_storage_pool_event_register_any_args {
>>> + int eventID;
>>> + remote_storage_pool pool;
>>> +};
>>> +struct remote_connect_storage_pool_event_register_any_ret {
>>> + int callbackID;
>>> +};
>>> +struct remote_connect_storage_pool_event_deregister_any_args {
>>> + int callbackID;
>>> +};
>>> +struct remote_storage_pool_event_lifecycle_msg {
>>> + int callbackID;
>>> + remote_nonnull_storage_pool pool;
>>> + int event;
>>> + int detail;
>>> +};
>>> struct remote_domain_fsfreeze_args {
>>> remote_nonnull_domain dom;
>>> struct {
>>>
>>
>> This looks like it's missing peter's suggested change to avoid the 'make
>> check' error (which I don't think you or I can reproduce but it seems to be
>> some other build system problem)
>>
>
> That's because you don't have dvarwes installed (that installs pdwtags
> which extracts this info that we can compare). It's just a matter of
> indentation.
I do have dwarves installed, but the makefile is complaining about pdwtags:
http://www.redhat.com/archives/libvir-list/2016-June/msg00899.html
That's with F24. Maybe jovanka is missing dwarves, she's on f23, or maybe the
f23 packages are similarly affected
- Cole
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list