Re: [PATCH] virHostCPUGetInfo: Fix build on non-Unix like systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 14, 2016 at 17:02:04 +0200, Michal Privoznik wrote:
> This function is plenty of ifdefs providing implementations for
> Linux, *BSD and OS-X. However, if we are being build for any
> other architecture, all that's left behind by preprocessor is
> just a error reporting call and return of -1. In that case,
> passed arguments are unused:
> 
> ../../src/util/virhostcpu.c: In function 'virHostCPUGetInfo':
> ../../src/util/virhostcpu.c:966:33: error: unused parameter 'cpus' [-Werror=unused-parameter]
>                    unsigned int *cpus,
>                                  ^~~~
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/util/virhostcpu.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Ah, this was not compiled until eaf18f4c.

ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]