Re: [PATCH] virt-login-shell: mark as Linux only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Daniel P. Berrange wrote:

> On Sun, Jun 12, 2016 at 12:11:09PM +0300, Roman Bogorodskiy wrote:
> > Currently, virt-login-shell is not allowed to build on Windows.
> > Howerver, as it's designed around LXC, it does not make sense to
> > build it on anything but Linux, so make the check strickter and allow to
> > enable it on Linux only.
> > ---
> >  m4/virt-login-shell.m4 | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4
> > index d5e2e00..55dcaf3 100644
> > --- a/m4/virt-login-shell.m4
> > +++ b/m4/virt-login-shell.m4
> > @@ -21,9 +21,9 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [
> >    m4_divert_text([DEFAULTS], [with_login_shell=check])
> >  
> >    if test "x$with_login_shell" != "xno"; then
> > -    if test "x$with_win" = "xyes"; then
> > +    if test "x$with_linux" != "xyes"; then
> >        if test "x$with_login_shell" = "xyes"; then
> > -        AC_MSG_ERROR([virt-login-shell is not supported on Windows])
> > +        AC_MSG_ERROR([virt-login-shell is supported on Linux only])
> >        else
> >          with_login_shell=no;
> >        fi
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]