Re: [PATCH 1/4] nodeinfo: fix build on non-Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 12, 2016 at 11:10:37AM +0300, Roman Bogorodskiy wrote:
> SYSFS_SYSTEM_PATH is only defined for Linux, however it's used outside
> of #ifdef __linux__ code, e.g. as the first argument to
> nodeCapsInitNUMAFake().
> 
> But as this argument's value is used on Linux only, it's safe to define
> SYSFS_SYSTEM_PATH to "fake" to get things built on FreeBSD.
> ---
>  src/nodeinfo.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/nodeinfo.c b/src/nodeinfo.c
> index 4e344bb..b02c294 100644
> --- a/src/nodeinfo.c
> +++ b/src/nodeinfo.c
> @@ -129,6 +129,8 @@ virNodeGetSiblingsListLinux(const char *dir, int cpu_id)
>      VIR_FREE(path);
>      return ret;
>  }
> +#else
> +# define SYSFS_SYSTEM_PATH "fake"
>  #endif

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]