Re: [ruby-libvirt] Don't make volume upload zero bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 10, 2016 at 11:10 AM, Guido Günther <agx@xxxxxxxxxxx> wrote:
The virStreamSourceFunc internal_sendall currently returns the first
value passed in from the block, which according the ruby-libvirt docs
should be zero:

  The send block should return an array of 2 elements; the first element
  should be the return code from the block (-1 for error, 0 otherwise)

But according to the libvirt docs of virStreamSourceFunc this indicates
EOF:

  Returns:  the number of bytes filled, 0 upon end of file, or -1 upon error

So return the size of the buffer to unbreak volume uploads.
 
This looks OK to me, so I applied it, thanks.  I really should add an example of virStream to the examples on the website; do you happen to have a relatively simple example that I could put up there?

Thanks,
Chris
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]