On Wed, Jun 08, 2016 at 09:58:50AM +0200, Peter Krempa wrote:
> On Tue, Jun 07, 2016 at 20:07:32 +0200, Ján Tomko wrote:
> > Instead of calling xmllint via a shell script, use our virXMLValidator
> > API to do it directly via libxml.
> > ---
> > .gitignore | 1 -
> > tests/Makefile.am | 28 ++----
> > tests/capabilityschematest | 9 --
> > tests/domaincapsschematest | 10 ---
> > tests/domainschematest | 14 ---
> > tests/domainsnapshotschematest | 9 --
> > tests/interfaceschematest | 9 --
> > tests/networkschematest | 9 --
> > tests/nodedevschematest | 9 --
> > tests/nwfilterschematest | 9 --
> > tests/schematestutils.sh | 47 ----------
> > tests/secretschematest | 9 --
> > tests/storagepoolschematest | 9 --
> > tests/storagevolschematest | 9 --
> > tests/virschematest.c | 190 +++++++++++++++++++++++++++++++++++++++++
> > 15 files changed, 196 insertions(+), 175 deletions(-)
> > create mode 100644 tests/virschematest.c
>
> [...]
>
> > +#define DO_TEST(schema, ...) \
> > + do { \
> > + if (testSchemaDirs(schema, __VA_ARGS__) < 0) \
> > + ret = -1; \
> > + } while (0) \
> > +
> > + DO_TEST("capability.rng", "capabilityschemadata", "xencapsdata", NULL);
>
> You can hide the 'NULL' sentinel inside the macro after __VA_ARGS__
>
> ACK with the problems fixed.
Thanks, I have pushed the series.
Jan
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list