Re: [PATCHv2 1/5] Introduce virXMLValidator structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 07, 2016 at 20:07:28 +0200, Ján Tomko wrote:
> Store all the data related to RNG validation in one structure to
> allow splitting virXMLValidateAgainstSchema.
> ---
>  src/util/virxml.c | 47 +++++++++++++++++++++++++++--------------------
>  src/util/virxml.h | 10 ++++++++++
>  2 files changed, 37 insertions(+), 20 deletions(-)

[...]

> @@ -177,6 +179,14 @@ int virXMLInjectNamespace(xmlNodePtr node,
>                            const char *uri,
>                            const char *key);
>  
> +typedef struct _virXMLValidator {
> +    xmlRelaxNGParserCtxtPtr rngParser;
> +    xmlRelaxNGPtr rng;
> +    xmlRelaxNGValidCtxtPtr rngValid;
> +    virBuffer buf;
> +    char *schemafile;
> +} virXMLValidator, *virXMLValidatorPtr;

This is too revolutionary. I'd stick with the few extra typedefs as we
do (almost) everywhere.

ACK with the above changed.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]