On Tue, Jun 07, 2016 at 05:15:55PM +0200, Ján Tomko wrote: > Currently, we spawn a new xmllint process for every tested XML file. > Fortunately, xmllint accepts multiple files on its command line. > > Use xargs on XML files we expect to be valid and only fall back > to file-by-file check if that fails (or if VIR_TEST_EXPENSIVE was requested). > > This speeds up successfully passing domainschematest 32x (from ~13s to ~0.5s) > and make check over 2x (over 16s to ~8s), making it even more fun to use with > git rebase -x. How about killing the horrible use of shell script and instead just calling virXMLValidateAgainstSchema() from a regular C unit test. That ought to reduce overhead even more and for added benefit eliminate awful shell script code. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list