On Fri, May 27, 2016 at 02:55:06PM +0200, Andrea Bolognani wrote: > The libsystemd-daemon library had been deprecated upstream > just a few days before we started using it. Talk about bad > timing :) > > With systemd 230, now in Debian sid and Fedora rawhide, it > has finally been dropped. We should use libsystemd, its > replacement, instead. > --- > configure.ac | 4 ++-- > libvirt.spec.in | 14 +++++++------- > m4/{virt-systemd-daemon.m4 => virt-libsystemd.m4} | 14 +++++++------- > src/Makefile.am | 4 ++-- > src/util/virsystemd.c | 4 ++-- > 5 files changed, 20 insertions(+), 20 deletions(-) > rename m4/{virt-systemd-daemon.m4 => virt-libsystemd.m4} (73%) Just unconditionally dropping support for libsystemd-daemon.so means you require systemd >= 209 for libvirt to build. IMHO this is too new. The only thing we use this for is sd_notify() which is a really trivial method which gets a NUIX socket from NOTIFY_SOCKET env variable, opens it and just sends across the string. I think we could just implement this logic trivially ourselvs, and not need to use any library, thus avoiding the problem with it being moved Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list