On 06/06/2016 03:23 AM, Peter Krempa wrote: > On Fri, Jun 03, 2016 at 06:52:51 -0400, John Ferlan wrote: >> Rather than open coding, follow the secinfo code and use the common >> secret object build/generate sequence. > > The main reason to do this was to have a single code path that generates > properties both for adding the object to qemu via commandline and via > monitor. Is this going to be used on the monitor? If not there's no > reason to do this. > The main reason to do this was to have the commandline code generating the master secret perform the same virJSON* call that the code for generating the AES secret uses. Not sure what the reference for via monitor is all about. If using common code isn't desire, then I can drop it. John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list