[PATCH 06/32] Assign node device driver private data earlier

[Ján Tomko <jtomko@xxxxxxxxxx>]

We do not need it to track if priv->udev_monitor is non-NULL.
---
 src/node_device/node_device_udev.c | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index c2f503d..f443d58 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -1499,14 +1499,16 @@ static int nodeStateCleanup(void)
 
     priv = driver->privateData;
 
-    if (priv->watch != -1)
-        virEventRemoveHandle(priv->watch);
+    if (priv) {
+        if (priv->watch != -1)
+            virEventRemoveHandle(priv->watch);
 
-    udev_monitor = DRV_STATE_UDEV_MONITOR(driver);
+        udev_monitor = DRV_STATE_UDEV_MONITOR(driver);
 
-    if (udev_monitor != NULL) {
-        udev = udev_monitor_get_udev(udev_monitor);
-        udev_monitor_unref(udev_monitor);
+        if (udev_monitor != NULL) {
+            udev = udev_monitor_get_udev(udev_monitor);
+            udev_monitor_unref(udev_monitor);
+        }
     }
 
     if (udev != NULL)
@@ -1726,12 +1728,11 @@ static int nodeStateInitialize(bool privileged,
         return -1;
     }
 
+    driver->privateData = priv;
     nodeDeviceLock();
 
-    if (udevPCITranslateInit(privileged) < 0) {
-        VIR_FREE(priv);
+    if (udevPCITranslateInit(privileged) < 0)
         goto out_unlock;
-    }
 
     /*
      * http://www.kernel.org/pub/linux/utils/kernel/hotplug/libudev/libudev-udev.html#udev-new
@@ -1747,16 +1748,12 @@ static int nodeStateInitialize(bool privileged,
 
     priv->udev_monitor = udev_monitor_new_from_netlink(udev, "udev");
     if (priv->udev_monitor == NULL) {
-        VIR_FREE(priv);
         VIR_ERROR(_("udev_monitor_new_from_netlink returned NULL"));
         goto out_unlock;
     }
 
     udev_monitor_enable_receiving(priv->udev_monitor);
 
-    /* udev can be retrieved from udev_monitor */
-    driver->privateData = priv;
-
     /* We register the monitor with the event callback so we are
      * notified by udev of device changes before we enumerate existing
      * devices because libvirt will simply recreate the device if we
-- 
2.7.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list