Re: [PATCH v3 1/5] qemu: Move and rename qemuBuildObjectCommandlineFromJSON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 03, 2016 at 06:52:49 -0400, John Ferlan wrote:
> Move the module from qemu_command.c to a new module virqemu.c and
> rename the API to virQEMUBuildObjectCommandline.
> 
> This API will then be shareable with qemu-img and the need to build
> a security object for luks support.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  po/POTFILES.in              |   1 +
>  src/Makefile.am             |   1 +
>  src/libvirt_private.syms    |   4 ++
>  src/qemu/qemu_command.c     | 126 +++------------------------------------
>  src/qemu/qemu_command.h     |   4 --
>  src/util/virqemu.c          | 142 ++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virqemu.h          |  34 +++++++++++
>  tests/qemucommandutiltest.c |   9 ++-
>  8 files changed, 195 insertions(+), 126 deletions(-)
>  create mode 100644 src/util/virqemu.c
>  create mode 100644 src/util/virqemu.h

[...]

> diff --git a/src/util/virqemu.c b/src/util/virqemu.c
> new file mode 100644
> index 0000000..f87e20b
> --- /dev/null
> +++ b/src/util/virqemu.c
> @@ -0,0 +1,142 @@
> +/*
> + * virqemu.c: QEMU object parsing/formatting

More like "utilities for working with qemu and its tools".

Same in the header.


ACK.

Peter

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]