Re: [PATCH 3/4] qemu: Move and rename qemuBuildSecretObjectProps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 27, 2016 at 09:57:09 -0400, John Ferlan wrote:
> Move the function to secret_util.c and rename to virSecretBuildObjectProps.
> This then can be shared with impending storage backend changes that will
> need to build up a secret object to pass to qemu-img.

This should be squashed with the previous commit.

> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/libvirt_private.syms |  1 +
>  src/qemu/qemu_command.c  | 63 +++---------------------------------------------
>  src/secret/secret_util.c | 59 +++++++++++++++++++++++++++++++++++++++++++++
>  src/secret/secret_util.h | 10 ++++++++
>  4 files changed, 73 insertions(+), 60 deletions(-)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index e4bddd3..0cd7a9c 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -1074,6 +1074,7 @@ nodeSetMemoryParameters;
>  
>  
>  # secret/secret_util.h
> +virSecretBuildObjectProps;

Also this is again too qemu specific for a generic helper.

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]