On Tue, May 31, 2016 at 12:33:27 +0200, Michal Privoznik wrote: > So the idea is as follows: firstly we obtain a list of all the > luns, then iterate over it trying to find the one we want to work > with and after all the iterations we detect whether we have found > something. Now, the last check is broken, because it compares a > value form previous iteration, not the one we've just been > through. > > Then, when computing md5 sum of lun's UUID, we use wrong variable > again. Well, @hostScsiDisk which is type of esxVI_HostScsiDisk > extends esxVI_ScsiLun type so they both have the uuid member, but > it just doesn't feel right to access the data via two different > variables in one function call. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/esx/esx_storage_backend_iscsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) ACK
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list