On 05/27/2016 10:24 AM, Eric Blake wrote: > On 05/27/2016 04:33 AM, Michal Privoznik wrote: > >>> >>> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged. >>> >> >> Unfortunately, this breaks build on my system: >> >> make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tests' CCLD virpcimock.la >> ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function `rpl_canonicalize_file_name': >> /home/zippy/work/libvirt/libvirt.git/gnulib/lib/canonicalize-lgpl.c:400: multiple definition of `rpl_canonicalize_file_name' >> .libs/virpcimock_la-virpcimock.o:/home/zippy/work/libvirt/libvirt.git/tests/virpcimock.c:939: first defined here >> collect2: error: ld returned 1 exit status >> >> Worse, I have no idea how to fix this. > > Was this an incremental or a clean build? If incremental, I suspect that > it may just be stale files left behind as gnulib shuffles things between > normal use and testsuite use. I'm trying to reproduce now... > > I'll pile on... me too... F23 gcc version 5.3.1 20160406 (Red Hat 5.3.1-6) (GCC) When the .gnulib is updated, I see autogen.sh being run - so what more "cleanup" would be required? A make clean doesn't help either. My setup is essentially "./autogen.sh --system"... John $ make -j12 check syntax-check INFO: gnulib update required; running ./autogen.sh first ./autogen.sh running bootstrap... ./bootstrap: Bootstrapping from checked-out libvirt sources... ./bootstrap: consider installing git-merge-changelog from gnulib ./bootstrap: getting gnulib files... Submodule path '.gnulib': checked out '6cc32c63e80bc1a30c521b2f07f2b54909b59892' ./bootstrap: autopoint --force running: libtoolize --install --copy libtoolize: error: 'build-aux/config.guess' is newer: use '--force' to overwrite libtoolize: error: 'build-aux/config.sub' is newer: use '--force' to overwrite ./bootstrap: .gnulib/gnulib-tool --import --no-changelog --aux-dir build-aux --doc-base doc --lib libgnu --m4-base m4/ --source-base gnulib/lib/ --tests-base gnulib/tests --local-dir gnulib/local --lgpl=2 --with-tests --makefile-name=gnulib.mk --avoid=pt_chown --avoid=lock-tests --libtool --import ... Module list with included dependencies (indented): absolute-header accept accept-tests alloca alloca-opt alloca-opt-tests allocator ... -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list