Similarly to post parse callbacks let's add infrastructure that will allow us to introduce checks that will reject configrations that were previously valid. This is achieved by flagging all the entry points to the config parser that need to ignore invadid configurations and adding a callback infrastructure for driver specific checks. Peter Krempa (10): conf: Rename VIR_DOMAIN_DEF_PARSE_VALIDATE to VIR_DOMAIN_DEF_PARSE_VALIDATE_SCHEMA conf: Add infrastructure for adding configuration validation conf: drop 'def' from struct virDomainDefPostParseDeviceIteratorData conf: Add device def validation callback qemu: process: Unexport qemuProcessStartValidate qemu: process: Convert multiple boolean args to a single flag qemu: process: Call the domain config validator when starting a new VM conf: Move disk info validator to the domain conf validator conf: Move validation of disk LUN device to the appropriate place qemu: Move check that validates 'min_guarantee' to qemuDomainDefValidate src/bhyve/bhyve_driver.c | 4 +- src/conf/domain_conf.c | 225 ++++++++++++++++++++++++++++++++++-------- src/conf/domain_conf.h | 31 +++++- src/conf/snapshot_conf.c | 3 +- src/conf/virdomainobjlist.c | 6 +- src/esx/esx_driver.c | 2 +- src/libvirt_private.syms | 2 +- src/libxl/libxl_domain.c | 3 +- src/libxl/libxl_driver.c | 10 +- src/libxl/libxl_migration.c | 6 +- src/lxc/lxc_driver.c | 7 +- src/openvz/openvz_driver.c | 7 +- src/phyp/phyp_driver.c | 2 +- src/qemu/qemu_domain.c | 20 +++- src/qemu/qemu_driver.c | 15 +-- src/qemu/qemu_migration.c | 14 ++- src/qemu/qemu_process.c | 42 ++++---- src/qemu/qemu_process.h | 9 +- src/security/virt-aa-helper.c | 3 +- src/test/test_driver.c | 4 +- src/uml/uml_driver.c | 7 +- src/vbox/vbox_common.c | 5 +- src/vmware/vmware_driver.c | 4 +- src/vz/vz_driver.c | 6 +- src/xen/xen_driver.c | 4 +- src/xen/xend_internal.c | 3 +- src/xen/xm_internal.c | 3 +- src/xenapi/xenapi_driver.c | 4 +- tests/qemuxml2argvtest.c | 6 +- 29 files changed, 325 insertions(+), 132 deletions(-) -- 2.8.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list