On 05/20/2016 11:21 PM, Jim Fehlig wrote: > On 05/19/2016 02:14 AM, Chunyan Liu wrote: >> This patch series is to support pvusb in libxl driver. >> >> --- >> Changes in v2: >> * add LIBXL_HAVE_PVUSB check >> * add convertion of domxml USB config to/from xl.cfg >> * address other comments >> >> Chunyan Liu (4): >> libxl: support creating guest with USB hostdev > > For this patch, I've fixed the nit Joao mentioned in my branch. > >> libxl: support hotplug USB host device > > See my suggested change to patch2, which I have squashed in my branch. > >> Add convertion domxml USB config to/from xl.cfg >> xlconfigtest: add test on USB convertion > > These look good. I've fixed the commit message nits in my local branch. Thanks > for adding the conversion and test! > > I'll wait for your thoughts on my change to patch2 (and any other comments from > Joao) before pushing the series. Jim, I have no further comments on patch 3 and 4 - these look good too. And based on discussion about your changes to patch 2 it all seems to be addressed too. Joao > I'd also like to try all the pvusb work you've > done in Xen and libvirt, but alas my test machine is having other problems now. > I'll get that fixed and do some testing on Monday. > > Regards, > Jim > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list