On 25.05.2016 00:53, John Ferlan wrote: > v1: > http://www.redhat.com/archives/libvir-list/2016-May/msg01611.html > > Although initially ACK'd by Erik, Jan pointed out something with one > of the patches and well this just lagged on my todo list. Since then > a change was made to lxc_driver.c (commit id '306b3a850') which caused > a merge conflict. > > So rather than push without checking first, I figure I'll make a v2. > > Patch 1 was already ACK'd > Patch 2 is new to remove persistentAddrs from qemu > Patch 3 is altered... I think the return from virDomainObjListRemove > will cause the 'vm' to be NULL anyway; however, since the next > called API virDomainObjEndAPI checks for that - it seems that > making that call won't hurt. I also moved the check to after > endjob, so that some sort of "failure" and goto cleanup doesn't > unexpectedly remove a transient domain. > > John Ferlan (3): > qemu: Remove dead code > qemu: Remove unused persistentAddrs > lxc: Fix lxcDomainDestroyFlags endjob processing > > src/lxc/lxc_driver.c | 6 ++---- > src/qemu/qemu_domain.h | 1 - > src/qemu/qemu_domain_address.c | 17 ++++------------- > src/qemu/qemu_process.c | 18 ++++++++---------- > 4 files changed, 14 insertions(+), 28 deletions(-) > ACK series. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list