On 05/22/2016 10:23 AM, John Ferlan wrote: > > > On 05/21/2016 10:22 AM, Mikhail Feoktistov wrote: >> --- >> src/util/vircrypto.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> > > Ugh... Sorry about this - forgot about the unused attributes <sigh> > > I should have just gone with the entire function w/ the > HAVE_GNUTLS_CIPHER_ENCRYPT macro instead of the intermixed > ATTRIBUTE_UNUSED as those would have a tendency for someone to come > along and try to patch again pointing out they are used without > realizing it was the gnutls macro that needed to be broader... > > I'll send something short with 2 patches that will do that. I started > working on the next task and realized I needed a slight adjustment anyway... FWIW there's an old BiteSizedTask about this type of issue wrt to GNUTLS: http://wiki.libvirt.org/page/BiteSizedTasks#Abstract_away_most_usage_of_WITH_GNUTLS So I guess this has come up before - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list