I've change the commit message summary to "xlconfigtest: add test for USB config conversion" in my local branch. Otherwise looks good. Thanks! Regards, Jim On 05/19/2016 02:14 AM, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx> > --- > tests/xlconfigdata/test-usb.cfg | 13 +++++++++++++ > tests/xlconfigdata/test-usb.xml | 35 +++++++++++++++++++++++++++++++++++ > tests/xlconfigtest.c | 1 + > 3 files changed, 49 insertions(+) > create mode 100644 tests/xlconfigdata/test-usb.cfg > create mode 100644 tests/xlconfigdata/test-usb.xml > > diff --git a/tests/xlconfigdata/test-usb.cfg b/tests/xlconfigdata/test-usb.cfg > new file mode 100644 > index 0000000..f0e616c > --- /dev/null > +++ b/tests/xlconfigdata/test-usb.cfg > @@ -0,0 +1,13 @@ > +name = "XenGuest1" > +uuid = "45b60f51-88a9-47a8-a3b3-5e66d71b2283" > +maxmem = 512 > +memory = 512 > +vcpus = 1 > +localtime = 0 > +on_poweroff = "preserve" > +on_reboot = "restart" > +on_crash = "preserve" > +vif = [ "mac=5a:36:0e:be:00:09" ] > +bootloader = "/usr/bin/pygrub" > +disk = [ "format=qcow2,vdev=xvda,access=rw,backendtype=qdisk,target=/var/lib/xen/images/debian/disk.qcow2" ] > +usbdev = [ "hostbus=1,hostaddr=3" ] > diff --git a/tests/xlconfigdata/test-usb.xml b/tests/xlconfigdata/test-usb.xml > new file mode 100644 > index 0000000..7b5853d > --- /dev/null > +++ b/tests/xlconfigdata/test-usb.xml > @@ -0,0 +1,35 @@ > +<domain type='xen'> > + <name>XenGuest1</name> > + <uuid>45b60f51-88a9-47a8-a3b3-5e66d71b2283</uuid> > + <memory unit='KiB'>524288</memory> > + <currentMemory unit='KiB'>524288</currentMemory> > + <vcpu placement='static'>1</vcpu> > + <bootloader>/usr/bin/pygrub</bootloader> > + <os> > + <type arch='x86_64' machine='xenpv'>linux</type> > + </os> > + <clock offset='utc' adjustment='reset'/> > + <on_poweroff>preserve</on_poweroff> > + <on_reboot>restart</on_reboot> > + <on_crash>preserve</on_crash> > + <devices> > + <disk type='file' device='disk'> > + <driver name='qemu' type='qcow2'/> > + <source file='/var/lib/xen/images/debian/disk.qcow2'/> > + <target dev='xvda' bus='xen'/> > + </disk> > + <interface type='ethernet'> > + <mac address='5a:36:0e:be:00:09'/> > + </interface> > + <console type='pty'> > + <target type='xen' port='0'/> > + </console> > + <input type='mouse' bus='xen'/> > + <input type='keyboard' bus='xen'/> > + <hostdev mode='subsystem' type='usb' managed='no'> > + <source> > + <address bus='1' device='3'/> > + </source> > + </hostdev> > + </devices> > +</domain> > diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c > index 6819bad..456f373 100644 > --- a/tests/xlconfigtest.c > +++ b/tests/xlconfigtest.c > @@ -229,6 +229,7 @@ mymain(void) > DO_TEST_FORMAT("fullvirt-direct-kernel-boot-bogus-extra"); > #endif > DO_TEST("vif-typename"); > + DO_TEST("usb"); > > virObjectUnref(caps); > virObjectUnref(xmlopt); -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list