On 05/20/2016 08:44 AM, Ján Tomko wrote: > Cleaning up after QEMU_CAPS_DEVICE I noticed QEMU_CAPS_DRIVE_READONLY > depends on it and QEMU_CAPS_PCIDEVICE did not really matter. > > Ján Tomko (9): > qemu_command: assume QEMU_CAPS_DEVICE > qemu: assume QEMU_CAPS_DEVICE almost everywhere > tests: remove disk-drive-fat test > tests: remove <readonly/> from IDE disks > tests: always assume QEMU_CAPS_DRIVE_READONLY > qemu: always assume QEMU_CAPS_DRIVE_READONLY > Deprecate QEMU_CAPS_DRIVE_READONLY > Deprecate QEMU_CAPS_DEVICE > Deprecate QEMU_CAPS_PCIDEVICE > > src/qemu/qemu_capabilities.c | 46 +-- > src/qemu/qemu_capabilities.h | 6 +- > src/qemu/qemu_command.c | 425 ++++++--------------- > src/qemu/qemu_command.h | 3 +- > src/qemu/qemu_domain.c | 6 +- > src/qemu/qemu_domain.h | 1 - > src/qemu/qemu_hostdev.c | 4 +- > src/qemu/qemu_hotplug.c | 61 +-- > src/qemu/qemu_process.c | 8 +- > tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_1.6.50.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 - > tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 - > .../caps_2.6.0-gicv2.aarch64.xml | 2 - > .../caps_2.6.0-gicv3.aarch64.xml | 2 - > tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 2 - > tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 - > tests/qemuhelptest.c | 45 +-- > tests/qemuhotplugtest.c | 2 - > .../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args | 3 +- > .../qemuxml2argv-boot-complex-bootindex.args | 3 +- > .../qemuxml2argv-boot-complex.args | 3 +- > ...xml2argv-boot-menu-disable-drive-bootindex.args | 3 +- > .../qemuxml2argv-boot-menu-disable-drive.args | 3 +- > .../qemuxml2argv-boot-menu-disable.args | 3 +- > ...qemuxml2argv-boot-menu-enable-with-timeout.args | 3 +- > .../qemuxml2argv-boot-menu-enable.args | 3 +- > .../qemuxml2argvdata/qemuxml2argv-boot-multi.args | 3 +- > .../qemuxml2argvdata/qemuxml2argv-boot-order.args | 3 +- > .../qemuxml2argvdata/qemuxml2argv-boot-strict.args | 3 +- > .../qemuxml2argv-controller-order.args | 2 +- > tests/qemuxml2argvdata/qemuxml2argv-disk-aio.args | 2 +- > .../qemuxml2argv-disk-blockio.args | 3 +- > .../qemuxml2argv-disk-cdrom-empty.args | 2 +- > .../qemuxml2argv-disk-cdrom-network-ftp.args | 2 +- > .../qemuxml2argv-disk-cdrom-network-ftps.args | 2 +- > .../qemuxml2argv-disk-cdrom-network-http.args | 2 +- > .../qemuxml2argv-disk-cdrom-network-https.args | 2 +- > .../qemuxml2argv-disk-cdrom-network-tftp.args | 2 +- > ...qemuxml2argv-disk-cdrom-tray-no-device-cap.args | 2 +- > .../qemuxml2argv-disk-cdrom-tray.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args | 3 +- > .../qemuxml2argv-disk-copy_on_read.args | 2 +- > .../qemuxml2argv-disk-drive-boot-cdrom.args | 2 +- > .../qemuxml2argv-disk-drive-boot-disk.args | 2 +- > .../qemuxml2argv-disk-drive-cache-directsync.args | 2 +- > .../qemuxml2argv-disk-drive-cache-unsafe.args | 2 +- > .../qemuxml2argv-disk-drive-cache-v2-none.args | 2 +- > .../qemuxml2argv-disk-drive-cache-v2-wb.args | 2 +- > .../qemuxml2argv-disk-drive-cache-v2-wt.args | 2 +- > .../qemuxml2argv-disk-drive-discard.args | 2 +- > ...uxml2argv-disk-drive-error-policy-enospace.args | 2 +- > .../qemuxml2argv-disk-drive-error-policy-stop.args | 2 +- > ...gv-disk-drive-error-policy-wreport-rignore.args | 2 +- > .../qemuxml2argv-disk-drive-fat.args | 22 -- > .../qemuxml2argv-disk-drive-fat.xml | 31 -- > .../qemuxml2argv-disk-drive-fmt-qcow.args | 2 +- > .../qemuxml2argv-disk-drive-no-boot.args | 2 +- > .../qemuxml2argv-disk-drive-shared.args | 2 +- > .../qemuxml2argv-disk-ide-drive-split.args | 3 +- > .../qemuxml2argv-disk-ioeventfd.args | 2 +- > .../qemuxml2argvdata/qemuxml2argv-disk-order.args | 2 +- > .../qemuxml2argv-disk-scsi-disk-split.args | 6 +- > .../qemuxml2argv-disk-scsi-disk-vpd.args | 6 +- > .../qemuxml2argv-disk-scsi-disk-wwn.args | 3 +- > .../qemuxml2argv-disk-snapshot.args | 2 +- > .../qemuxml2argv-disk-source-pool-mode.args | 5 +- > .../qemuxml2argv-disk-source-pool.args | 5 +- > .../qemuxml2argvdata/qemuxml2argv-disk-virtio.args | 2 +- > tests/qemuxml2argvdata/qemuxml2argv-event_idx.args | 2 +- > .../qemuxml2argv-floppy-drive-fat.args | 2 +- > .../qemuxml2argv-graphics-spice-timeout.args | 2 +- > .../qemuxml2argv-hugepages-numa.args | 2 +- > .../qemuxml2argv-pci-autoadd-addr.args | 3 +- > .../qemuxml2argv-pci-autoadd-idx.args | 3 +- > tests/qemuxml2argvdata/qemuxml2argv-pci-many.args | 3 +- > .../qemuxml2argv-seclabel-dynamic-override.xml | 1 - > tests/qemuxml2argvtest.c | 43 +-- > .../qemuxml2xmlout-seclabel-dynamic-override.xml | 1 - > tests/qemuxml2xmltest.c | 2 - > 85 files changed, 246 insertions(+), 631 deletions(-) > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml > Other than the unexpected removal of FSDEV_READONLY in patch 6, looks good - ACK series modulo addressing that John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list