On Thu, May 19, 2016 at 05:29:41PM -0400, John Ferlan wrote: > > > On 05/19/2016 02:59 PM, Ján Tomko wrote: > > For some disk types (XEN, SD), we want to emit the syntax > > Removed XEN in patch 4 I thought... > > > we used for disks before -device was available even > > if QEMU supports -device. > > > > Use the qemuDiskBusNeedsDeviceArg helper to figure out > > whether to use the old or new syntax. > > --- > > src/qemu/qemu_command.c | 12 +++--------- > > 1 file changed, 3 insertions(+), 9 deletions(-) > > > > The rest seems fine - although connecting the dots between CAPS_DEVICE > and bus != BUS_SD wasn't as obvious... It's the double negative of > qemuDiskBusNeedsDeviceArg to set deviceFlagMasked that caused me to pause. > > > ACK series with a few touchups. > Thanks, pushed now. Jan -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list