On 05/17/2016 10:25 AM, Peter Krempa wrote:
> Name the validation function distinctively since it's called in the
> parser. Later patches will add function that will validate disk
> definitions that are invalid but need to be parsed to avoid losing
> domains.
> ---
> src/conf/domain_conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index b445469..12f9da2 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -6932,7 +6932,7 @@ virDomainDiskDefGeometryParse(virDomainDiskDefPtr def,
>
>
> static int
> -virDomainDiskDefValidate(const virDomainDiskDef *def)
> +virDomainDiskDefParseValidate(const virDomainDiskDef *def)
> {
> if (def->bus != VIR_DOMAIN_DISK_BUS_VIRTIO) {
> if (def->event_idx != VIR_TRISTATE_SWITCH_ABSENT) {
> @@ -7537,7 +7537,7 @@ virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt,
> goto error;
> }
>
> - if (virDomainDiskDefValidate(def) < 0)
> + if (virDomainDiskDefParseValidate(def) < 0)
> goto error;
>
> cleanup:
>
ACK, and could be pushed now
- Cole
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list