On 05/19/2016 12:48 PM, Michal Privoznik wrote:
> On 18.05.2016 16:53, Michal Privoznik wrote:
>> On 16.05.2016 23:36, Katerina Koukiou wrote:
>>> This patch series adds job support to the lxc driver, using techiques from the
>>> libxl driver. One benefit is no longer blocking get operations during long
>>> running modify operations. E.g. with these patches 'vish dominfo dom' will
>>> work while 'virsh save dom ...' is in progress.
>>>
>>> The first patch adds the job support machinery, followed by several patches
>>> that make use of it.
>>> Although this might look not needed that much right now, it is preparing
>>> environment for future work.
>>>
>>> This patch series has been reviewed by Michal Privoznik who is my mentor
>>> for GSoC 2016.
>>>
>>>
>>> Katerina Koukiou (8):
>>> lxc: Add job support to lxc driver
>>> lxc: use job functions in lxcDomain{CreateXMLWithFiles,
>>> CreateWithFiles}
>>> lxc: use job functions in lxcDomainSetMemoryFlags
>>> lxc: use job functions in lxcDomain{Suspend, Resume}
>>> lxc: use job functions in lxcDomain{AttachDeviceFlags,
>>> DetachDeviceFlags, UpdateDeviceFlags}
>>> lxc: add job functions in lxcDomainSetAutostart
>>> lxc: use job functions in lxcDomain* functions that do query
>>> operations.
>>> lxc: use job functions in lxcDomain* functions that perform modify
>>> actions.
>>>
>>> src/lxc/lxc_domain.c | 154 ++++++++++++++++++++--
>>> src/lxc/lxc_domain.h | 37 ++++++
>>> src/lxc/lxc_driver.c | 351 ++++++++++++++++++++++++++++++++++++---------------
>>> 3 files changed, 428 insertions(+), 114 deletions(-)
>>>
>>
>> ACK series, although, I'll leave others time to chime in before pushing.
>
> Okay, nobody objected, so I've pushed these. Congratulations on your
> first libvirt contribution!
>
I had glanced over them and they looked quite good to me. Nice work Katerina!
- Cole
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list