On Tue, 2016-05-17 at 16:10 -0400, John Ferlan wrote: > > On 05/16/2016 06:00 PM, Andrea Bolognani wrote: > > > > The only case where the hardware capabilities influence the result > > is when no <gic/> element was provided. > > > > The test programs now ensure both that the correct GIC version is > > picked in that case, and that hardware capabilities are not taken > > into account when the user has already picked a GIC version. > > --- > > .../qemuxml2argv-aarch64-gic-none-both.args | 1 + > > .../qemuxml2argv-aarch64-gic-none-both.xml | 1 + > > .../qemuxml2argv-aarch64-gic-none-v2.args | 1 + > > .../qemuxml2argv-aarch64-gic-none-v2.xml | 1 + > > .../qemuxml2argv-aarch64-gic-none-v3.args | 1 + > > .../qemuxml2argv-aarch64-gic-none-v3.xml | 1 + > > tests/qemuxml2argvtest.c | 76 ++++++++++++++++++---- > > .../qemuxml2xmlout-aarch64-gic-none-both.xml | 1 + > > .../qemuxml2xmlout-aarch64-gic-none-v2.xml | 1 + > > .../qemuxml2xmlout-aarch64-gic-none-v3.xml | 1 + > > tests/qemuxml2xmltest.c | 25 +++++-- > > 11 files changed, 91 insertions(+), 19 deletions(-) > > create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-both.args > > create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-both.xml > > create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v2.args > > create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v2.xml > > create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v3.args > > create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v3.xml > > create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-both.xml > > create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-v2.xml > > create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-v3.xml > > > This failed to apply - seemingly because there's QEMU_CAPS_CPU_HOST in > here that has changed since you posted to X_QEMU_CAPS_CPU_HOST > > But if I very carefully massage it, I was able to run the test - nothing > like testing the crap out of things! > > So ACK with the I hope obvious adjustment to remove QEMU_CAPS_CPU_HOST Funny thing is, I'm the one who removed QEMU_CAPS_CPU_HOST in the fist place ;) Anyway, as you mentioned, the fix is very obvious. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list