On 05/16/2016 10:07 AM, John Ferlan wrote: > > > On 05/08/2016 02:43 PM, Cole Robinson wrote: >> This series adds qemu cli comma escaping to several places that >> are dependent on the VM name, to enable names with embedded commas. >> >> Patch 6 makes use of qemu -name guest=X value to allow names with >> '=' in them. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=639926 >> https://bugzilla.redhat.com/show_bug.cgi?id=1276485 >> >> Note: There's likely other places that are VM name dependent that need >> comma escaping too, but this hits the mandatory ones. I've listed some >> more on the BiteSizedTasks page: >> >> http://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values >> >> >> v3: >> Patch 1 and patch 4 are new >> >> Cole Robinson (6): >> qemu: command: Add qemuBufferEscapeComma >> qemu: command: escape commas in VM name >> qemu: command: escape commas in secret master path >> qemu: command: escape commas in VNC socket path >> qemu: command: escape commas in chardev socket path >> qemu: command: Use -name guest= if available >> >> src/qemu/qemu_capabilities.c | 2 + >> src/qemu/qemu_capabilities.h | 1 + >> src/qemu/qemu_command.c | 50 ++++++++++++++++------ >> tests/qemucapabilitiesdata/caps_2.1.1-1.x86_64.xml | 1 + >> tests/qemucapabilitiesdata/caps_2.4.0-1.x86_64.xml | 1 + >> tests/qemucapabilitiesdata/caps_2.5.0-1.x86_64.xml | 1 + >> .../qemucapabilitiesdata/caps_2.6.0-1.aarch64.xml | 1 + >> .../qemucapabilitiesdata/caps_2.6.0-1.ppc64le.xml | 1 + >> tests/qemucapabilitiesdata/caps_2.6.0-1.x86_64.xml | 1 + >> .../qemucapabilitiesdata/caps_2.6.0-2.aarch64.xml | 1 + >> tests/qemucaps2xmldata/all_1.6.0-1.caps | 1 + >> tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps | 1 + >> .../qemuxml2argvdata/qemuxml2argv-name-escape.args | 25 +++++++++++ >> .../qemuxml2argvdata/qemuxml2argv-name-escape.xml | 19 ++++++++ >> tests/qemuxml2argvtest.c | 3 ++ >> 15 files changed, 96 insertions(+), 13 deletions(-) >> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.args >> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.xml >> > > I think you know you'll have "adjustments" with patch 6 based on recent > upstream changes to those caps* files... But, as odd as I find the need > for comma's and equal signs in the guest name and seeing as no other > agita over this has been brought up... > > ACK series Thanks, pushed now - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list