I also wanted to get rid of yet another copy of virSecretGetSecretString in the RBD driver code but I didn't figure out the linking yet, so I'll send the patch separately. John Ferlan (2): util: string: Introduce helper to determine whether a byte buffer is printable secret: Alter virSecretGetSecretString Peter Krempa (4): util: alloc: Introduce freeing helpers that clear the memory before freeing secret: util: Refactor virSecretGetSecretString util: string: Introduce virStringEncodeBase64 qemu: domain: Fix names for functions that clear security info po/POTFILES.in | 1 - src/conf/virsecretobj.c | 7 +--- src/libvirt_private.syms | 3 ++ src/libxl/libxl_conf.c | 23 +++++++----- src/qemu/qemu_agent.c | 6 +-- src/qemu/qemu_command.c | 18 +++++++-- src/qemu/qemu_domain.c | 27 +++++-------- src/qemu/qemu_domain.h | 3 +- src/secret/secret_util.c | 79 +++++++++++---------------------------- src/secret/secret_util.h | 12 +++--- src/storage/storage_backend_rbd.c | 17 ++------- src/util/viralloc.c | 36 ++++++++++++++++++ src/util/viralloc.h | 56 +++++++++++++++++++++++++++ src/util/virstring.c | 43 +++++++++++++++++++++ src/util/virstring.h | 3 ++ tests/viralloctest.c | 37 ++++++++++++++++++ tools/virsh-secret.c | 6 +-- 17 files changed, 256 insertions(+), 121 deletions(-) -- 2.8.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list