On Tue, Apr 07, 2009 at 05:16:30PM -0400, David Allan wrote: > > This patch implements NPIV support. I don't have easy access to an > NPIV capable switch at the moment, so this is all untested code at > least from the perspective of whether it actually creates and deletes > virtual adapters, but I thought I should get it out to the list for > comment sooner rather than later. I'll have a switch shortly. If > anybody has an NPIV capable test SAN and wants to test it as well, I'd > much appreciate the feedback. > > Note that libvirt doesn't do any sanity checking of the WWPN/WWNN. It > expects the kernel to verify that the names are valid and the calling > application to verify that the names are appropriate for the fabric. I've just thought of one other aspect of this. Not all SCSI HBAs have the ability to create/delete NPIV vHBAs. So we likely want to extend the virNodeDevicePtr XML format to add a feature flag indicating whether NPIV is supported for each HBA that is reported. Also since crating new vHBAs will also result in new virNodeDevicePtr appearing, we likely want to also add a flag indicating that a particular HBA is a virtual one & thus deletable. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list